Use doOnDiscard to release cached Payloads#777
Merged
Conversation
cba41f0 to
626dd81
Compare
Member
Author
|
Blocked due to reactor/reactor-core#2114 |
d761e59 to
942a33d
Compare
rstoyanchev
requested changes
Apr 18, 2020
rstoyanchev
left a comment
Contributor
There was a problem hiding this comment.
Looks good, very important change!
A few comments and questions below. Also update copyrights and add one for CleanOnClearQueueDecorator.
OlegDokuka
commented
Apr 18, 2020
OlegDokuka
commented
Apr 18, 2020
rstoyanchev
approved these changes
Apr 18, 2020
f21ce2e to
13a4fbb
Compare
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
… released in case of racing Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
part of the tests are on racing (ignored for now) another few on verification that elements are discarded properly Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Ensures there is no leaks in RSocketRequesterTest and RSocketResponder tests Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
0a25208 to
4743921
Compare
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
4743921 to
1595288
Compare
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
75445c1 to
8a3103e
Compare
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
8a3103e to
edf6788
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I wanna introduce extra hooks to ensure we capture and release all the discarded payloads.
In this case, I use
doOnDiscardoperator in order to release dropped elements for every stream we have.Also, just for now, I created an extra class for
Queuewrapping in order to ensure thatUnicastProcesssordoes not leak elements on cancellationPlease note, this PR does not address all the cases and a user still MUST install
Hooks.onNextDroppedto ensure there are no leaks if a payload goes beyond rsocket internals scope.Signed-off-by: Oleh Dokuka shadowgun@i.ua