Fix the equality parity issue

rrousselGit · Sep 9, 2025 · Aug 27, 2025 · Aug 27, 2025 · Aug 27, 2025 · Aug 27, 2025
commit bcbb92773ad6037846035e3fb39fc1c0a2077302
diff --git a/packages/riverpod/lib/src/core/mutations.dart b/packages/riverpod/lib/src/core/mutations.dart
@@ -516,9 +516,11 @@ final class MutationImpl<ResultT>
     );
   }
 
+  bool _matchesT(Mutation<Object?> other) => other is Mutation<ResultT>;
+
   @override
   bool operator ==(Object other) {
-    if (other is! MutationImpl<ResultT>) return false;
+    if (other is! MutationImpl<ResultT> || !other._matchesT(this)) return false;
     if (_key != null) return _key == other._key;
 
     return super == other;

diff --git a/packages/riverpod/test/feature/mutation_test.dart b/packages/riverpod/test/feature/mutation_test.dart
@@ -27,11 +27,17 @@ void main() {
     final mut = Mutation<num>();
     final mutInt = mut<int>(null);
     final mutDouble = mut<double>(null);
+
+    final confusingMut = mut<num>(null);
     // none should be equal
     expect(mut, isNot(mutInt));
     expect(mut, isNot(mutDouble));
     expect(mutInt, isNot(mutDouble));
 
+    // check for type equality parity
+    expect(confusingMut, isNot(mutInt));
+    expect(mutInt, isNot(confusingMut));
+
     // shows that using the same generic
     // with the same key will get the correct value
     expect(mutInt, equals(mut<int>(null)));