Skip to content

Commit 4efaf80

Browse files
yakov116fregante
andauthored
Abbreviate bugs-tab and releases-tab count (refined-github#4108)
Co-authored-by: Federico <me@fregante.com>
1 parent 58fec10 commit 4efaf80

5 files changed

Lines changed: 18 additions & 12 deletions

File tree

‎package-lock.json‎

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
"github-url-detection": "^4.9.1",
6464
"image-promise": "^7.0.1",
6565
"indent-textarea": "^2.0.3",
66-
"js-abbreviation-number": "^1.0.0",
66+
"js-abbreviation-number": "^1.1.2",
6767
"linkify-issues": "2.0.0-nolookbehind",
6868
"linkify-urls": "3.1.0-nolookbehind",
6969
"mem": "^8.0.0",

‎source/features/bugs-tab.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ import features from '.';
99
import * as api from '../github-helpers/api';
1010
import {getRepo} from '../github-helpers';
1111
import SearchQuery from '../github-helpers/search-query';
12+
import abbreviateNumber from '../helpers/abbreviate-number';
1213

13-
const numberFormatter = new Intl.NumberFormat();
1414
const countBugs = cache.function(async (): Promise<number> => {
1515
const {search} = await api.v4(`
1616
search(type: ISSUE, query: "label:bug is:open is:issue repo:${getRepo()!.nameWithOwner}") {
@@ -93,7 +93,7 @@ async function init(): Promise<void | false> {
9393

9494
// Update bugs count
9595
try {
96-
bugsCounter.textContent = numberFormatter.format(await countPromise);
96+
bugsCounter.textContent = abbreviateNumber(await countPromise);
9797
} catch (error: unknown) {
9898
bugsCounter.remove();
9999
features.error(__filebasename, error);

‎source/features/releases-tab.tsx‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import features from '.';
99
import * as api from '../github-helpers/api';
1010
import looseParseInt from '../helpers/loose-parse-int';
1111
import {appendBefore} from '../helpers/dom-utils';
12+
import abbreviateNumber from '../helpers/abbreviate-number';
1213
import {createDropdownItem} from './more-dropdown';
1314
import {buildRepoURL, getRepo} from '../github-helpers';
1415

@@ -77,7 +78,7 @@ async function init(): Promise<false | void> {
7778
>
7879
<TagIcon className="UnderlineNav-octicon"/>
7980
<span data-content="Releases">Releases</span>
80-
{count && <span className="Counter">{count}</span>}
81+
{count && <span className="Counter">{abbreviateNumber(count)}</span>}
8182
</a>
8283
);
8384

@@ -117,7 +118,7 @@ async function init(): Promise<false | void> {
117118
<a href={buildRepoURL('releases')} className="reponav-item" data-hotkey="g r">
118119
<TagIcon/>
119120
<span> Releases </span>
120-
{count && <span className="Counter">{count}</span>}
121+
{count && <span className="Counter">{abbreviateNumber(count)}</span>}
121122
</a>
122123
);
123124

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
import {abbreviateNumber as abbreviateNumber_} from 'js-abbreviation-number';
2+
3+
export default function abbreviateNumber(number: number, digits = 1): string {
4+
return abbreviateNumber_(number, digits, {padding: false}).toLowerCase();
5+
}

0 commit comments

Comments
 (0)