Skip to content

Abbreviate bugs-tab and releases-tab count - #4108

Merged
yakov116 merged 8 commits into
mainfrom
abbrBugs
Mar 16, 2021
Merged

Abbreviate bugs-tab and releases-tab count#4108
yakov116 merged 8 commits into
mainfrom
abbrBugs

Conversation

@yakov116

@yakov116 yakov116 commented Mar 16, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #4107

Test URLs

https://github.com/microsoft/vscode

Screenshot

Before
image

After
image

Question should we replace .0?

Without the .0

image

fregante
fregante approved these changes Mar 16, 2021
View reviewed changes

@fregante fregante left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@yakov116

yakov116 commented Mar 16, 2021

Copy link
Copy Markdown
Member Author

Question should we replace .0?

?

kidonng
kidonng reviewed Mar 16, 2021
View reviewed changes
Comment thread source/features/bugs-tab.tsx Outdated
@fregante

fregante commented Mar 16, 2021

Copy link
Copy Markdown
Member

https://github.com/moh3n9595/js-abbreviation-number#usage

@yakov116

yakov116 commented Mar 16, 2021

Copy link
Copy Markdown
Member Author

moh3n9595/js-abbreviation-number#usage

I saw that

Using abbreviateNumber(number, 0) will round everything to the nearest 1000.

For example abbreviateNumber(1500, 0) => 2K that is not what we want.

@fregante

fregante commented Mar 16, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Ew… we can either find an alternative (micro) module or import it, adjust it, re-export it from a file under the helpers, so the same can be used in the other feature that uses js-abbreviation-number

Edit: I'm gonna open an issue, maybe we can just adjust it and re-export it for now

@fregante
fregante marked this pull request as draft March 16, 2021 19:58
@yakov116

yakov116 commented Mar 16, 2021

Copy link
Copy Markdown
Member Author

I will cleanup the lock later.

Should should I make a helper called issueNumberFormat?

fregante
fregante reviewed Mar 16, 2021
View reviewed changes
Comment thread source/features/bugs-tab.tsx Outdated
@yakov116 @fregante
Update source/features/bugs-tab.tsx
85cb305 
Co-authored-by: Federico <me@fregante.com>
fregante
fregante reviewed Mar 16, 2021
View reviewed changes
Comment thread webpack.config.ts
),

__filebasename: webpack.DefinePlugin.runtimeValue(
// @ts-expect-error

@fregante fregante Mar 16, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep unrelated package-lock changes for the next lint. I added some lines in #4111 because they are macOS-specific and always get added by npm i, just for macOS users :(

@yakov116 yakov116 Mar 16, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am doing it now. I was just so mad I wanted to just commit and fix it up.

@yakov116 yakov116 changed the title Abbreviate bugs-tab count Abbreviate bugs-tab and releases-tab count Mar 16, 2021
@yakov116
yakov116 marked this pull request as ready for review March 16, 2021 22:22
fregante
fregante reviewed Mar 16, 2021
View reviewed changes
Comment thread source/helpers/issue-number-format.ts Outdated
@yakov116
yakov116 merged commit 4efaf80 into main Mar 16, 2021
@yakov116
yakov116 deleted the abbrBugs branch March 16, 2021 23:26
@Geeyun-JY3 Geeyun-JY3 mentioned this pull request Mar 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kidonng kidonng kidonng left review comments
@fregante fregante fregante approved these changes

Assignees

No one assigned

Labels

change request

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use 1k instead of 1000 in bugs-tab

3 participants

@yakov116 @fregante @kidonng