Prevent .called_ prefix calls in mocks until we upgrade to python 3.12#22
Closed
Prevent .called_ prefix calls in mocks until we upgrade to python 3.12#22
Conversation
carlosa54
commented
Nov 4, 2024
tomharel
previously approved these changes
Nov 4, 2024
tomharel
previously approved these changes
Nov 5, 2024
justmobilize
approved these changes
Nov 5, 2024
tomharel
approved these changes
Nov 6, 2024
Author
|
I encountered some false positives when testing these new rules that would require a more complex code to be able to identify them, closing this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds rule to prevent
.called_ prefix, .has_calls, .not_calledto be called in mocksThis rule should be removed when we update to python 3.12 since it should be handled automatically. They included this in python/cpython#100691