Skip to content

Implemented the approved compatibility-first reliability improvements. - #3

Open
digisamu wants to merge 1 commit into
roma:masterfrom
digisamu:main
Open

digisamu wants to merge 1 commit into
roma:masterfrom
digisamu:main

Conversation

@digisamu

@digisamu digisamu commented Oct 9, 2026

Copy link
Copy Markdown

Key changes:

  • Prevented truncated/EOF responses from looping indefinitely; exact reads now fail with IOException and flow through existing client error handling.
  • Preserved ROMA wire framing; added regression tests for exact get and set ESC/CRLF request bytes.
  • Fixed optimized multi-get connection leaks: healthy connections return to the pool; failed ones are invalidated; socket timeouts are applied.
  • Made optimized executor lifecycle safer and preserved interruption.
  • Improved socket-pool validation and close behavior.
  • Repaired HashMapConnectionPoolImpl cleanup, invalidation, idle-size enforcement, and socket closure.
  • Made retry/settings visibility safer and preserved thread interrupts.
  • Improved routing updater shutdown and protected routing-node list exposure.
  • Allowed a closed RomaClientImpl to be opened again without nulling its routing table.

Copilot AI balanced review requested due to automatic review settings October 9, 2026 19:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants