Skip to content

ci: use node 24#5949

Merged
lukastaegert merged 10 commits intorollup:masterfrom
btea:ci/test-use-node-24
May 18, 2025
Merged

ci: use node 24#5949
lukastaegert merged 10 commits intorollup:masterfrom
btea:ci/test-use-node-24

Conversation

@btea
Copy link
Copy Markdown
Contributor

@btea btea commented May 7, 2025

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

https://github.com/nodejs/node/releases/tag/v24.0.0

@vercel
Copy link
Copy Markdown

vercel Bot commented May 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2025 4:44am

@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.77%. Comparing base (7759f56) to head (b92331f).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5949   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files         270      270           
  Lines        8726     8727    +1     
  Branches     1504     1505    +1     
=======================================
+ Hits         8619     8620    +1     
  Misses         73       73           
  Partials       34       34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@btea
Copy link
Copy Markdown
Contributor Author

btea commented May 7, 2025 •
edited
Loading

Node24 is also the same as node 22.12.0. The error message is different from 22.11.0, which will cause the test to fail.

rollup/.github/workflows/build-and-tests.yml

Lines 501 to 503 in 02da7ef

- '18.20.0'
# There is a bug in 22.12.0 that sometimes makes the loadConfigFile tests fail
- '22.11.0'

In response to this situation, I modified the judgment condition of the test case. However, I am not sure whether this is appropriate.

@lukastaegert
Copy link
Copy Markdown
Member

lukastaegert commented May 9, 2025

I wonder if the problem is the native support for requiring ES modules. Then maybe we need to skip the test Node >= 22, or run a different test instead.

@btea
Copy link
Copy Markdown
Contributor Author

btea commented May 10, 2025 •
edited
Loading

It seems that the warning messages given by the node when loading es module in versions 22.11.0 and 24.0.0 are different, resulting in different results of the following judgment logic, which leads to test failure. ref nodejs/node#56628

rollup/cli/run/loadConfigFile.ts

Lines 63 to 67 in 7536ffb

const handleWarning = (warning: Error): void => {
if (warning.message.includes('To load an ES module')) {
cannotLoadEsm = true;
}
};

22.11.0 screen

image

24.0.0 screen

image

@lukastaegert
Copy link
Copy Markdown
Member

lukastaegert commented May 16, 2025

Ah, then the test is still useful. Nice!

@lukastaegert lukastaegert enabled auto-merge May 16, 2025 15:09
@lukastaegert lukastaegert force-pushed the ci/test-use-node-24 branch from b3fb36d to 8f47f7f Compare May 18, 2025 04:27
@lukastaegert lukastaegert force-pushed the ci/test-use-node-24 branch from 8f47f7f to b92331f Compare May 18, 2025 04:43
@lukastaegert lukastaegert added this pull request to the merge queue May 18, 2025
Merged via the queue into rollup:master with commit 2491b31 May 18, 2025
41 checks passed
@btea btea deleted the ci/test-use-node-24 branch May 18, 2025 05:28
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2025

This PR has been released as part of rollup@4.41.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@btea @lukastaegert