Same alias should not open new browser#1374
Merged
aaltat merged 5 commits intorobotframework:masterfrom Apr 22, 2019
Merged
Conversation
aaltat
commented
Apr 21, 2019
aaltat
commented
Apr 21, 2019
Contributor
Author
|
TODO: Fix |
Contributor
Author
|
And it looks like I broke something with the Python 2 compatibility. Need to look it more closely. |
Contributor
Author
|
It was not Python 2 but it was RF 3.0.4. When using string None as alias, it returned index which was already closed. But it was a good thing, because it lead me think few other cases and it did reveal few bugs in the code. Now I hope that it is fixed and working. FYI @rasjani I think your PR did ran in to same problem, this did fix the problem: https://github.com/robotframework/SeleniumLibrary/pull/1374/files#diff-566132cdf5a534d7e99598e5acc77378R243 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1319