Allow extra arguments for CookieInformation#1310
Merged
Merged
Conversation
Contributor
Author
|
Not good enough, order of keys will be random and causes inconsistency. |
Member
|
I'd just use instead of adding separate attributes for all this non-standard info. Not sure should it even be listed in |
Contributor
Author
|
Good point and it sounds like a better idea. At least it's easier to and needs some extra documentation. |
Contributor
Author
|
Didn't mean to close the PR. |
pekkaklarck
reviewed
Feb 16, 2019
| self.httpOnly = httpOnly | ||
| self.expiry = datetime.fromtimestamp(expiry) if expiry else None | ||
| if extra: | ||
| self.extra = extra |
Member
There was a problem hiding this comment.
Conditionally setting or not setting attribute is a bit of an anti-pattern. Is there some benefit here?
Contributor
Author
There was a problem hiding this comment.
That is true. Although I did explain it in the docs. Will change.
pekkaklarck
approved these changes
Feb 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1307