fix: allow add data, metrics view, and connector modals to scroll#9201
Merged
fix: allow add data, metrics view, and connector modals to scroll#9201
Conversation
These modals used fixed centering with no max-height constraint, causing content to overflow past the viewport with no way to scroll. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The middle section used `size-full` which made it 100% of the parent height instead of taking remaining space, clipping the DatabaseExplorer. Changed to `flex-1 min-h-0` so it fills available space and allows inner scroll. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The form used `h-full` which ignored the ConnectorHeader above it, overshooting available space. Changed to `flex-1 min-h-0` so it fills remaining space. Also added `min-h-0` to the DatabaseExplorer wrapper so it can shrink and enable inner scrolling. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Made the DatabaseExplorer parent div a flex-col container and added flex-1 min-h-0 to the DatabaseExplorer wrapper so it fills available space and overflow-y-auto can activate. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
These dialogs are small enough that they won't overflow the viewport. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
AdityaHegde
approved these changes
Apr 9, 2026
Contributor
Author
|
flaky e23 |
royendo
added a commit
that referenced
this pull request
Apr 9, 2026
) * fix: allow add data, metrics view, and connector modals to scroll These modals used fixed centering with no max-height constraint, causing content to overflow past the viewport with no way to scroll. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: make ImportTableForm database explorer scrollable The middle section used `size-full` which made it 100% of the parent height instead of taking remaining space, clipping the DatabaseExplorer. Changed to `flex-1 min-h-0` so it fills available space and allows inner scroll. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: properly constrain ImportTableForm height for scrolling The form used `h-full` which ignored the ConnectorHeader above it, overshooting available space. Changed to `flex-1 min-h-0` so it fills remaining space. Also added `min-h-0` to the DatabaseExplorer wrapper so it can shrink and enable inner scrolling. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: complete flex chain for DatabaseExplorer scrolling Made the DatabaseExplorer parent div a flex-col container and added flex-1 min-h-0 to the DatabaseExplorer wrapper so it fills available space and overflow-y-auto can activate. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * revert: remove unnecessary scroll changes from small dialogs These dialogs are small enough that they won't overflow the viewport. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
max-h-[90vh] overflow-y-autotoAddDataModal,CreateExploreDialog, andAddAiConnectorDialogoverflow-hiddenwith scrollable overflow on the sourcesAddDataModalAddDataModal(add-data/AddDataModal.svelte)Checklist:
Developed in collaboration with Claude Code