Skip to content

fix: broken spm package if added to multiple targets#3

Open
farfromrefug wants to merge 2 commits intorigor789:feat/spm-package-supportfrom
farfromrefug:patch-1
Open

fix: broken spm package if added to multiple targets#3
farfromrefug wants to merge 2 commits intorigor789:feat/spm-package-supportfrom
farfromrefug:patch-1

Conversation

@farfromrefug
Copy link
Copy Markdown

This is needed for an upcoming PR on the cli for more complex appwatch projects

Copy link
Copy Markdown
Owner

@rigor789 rigor789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this change is required, this will result in duplicate entries if executed multiple times, ie. rebuilding without clearing/re-creating the xcode project.

Comment thread packages/project/src/ios/spm.ts Outdated
@farfromrefug
Copy link
Copy Markdown
Author

@rigor789 thanks and sorry for the typo. FIxed

@NathanWalker
Copy link
Copy Markdown

We can combine this change with #2 @rigor789 or switch CLI back to your package. I think we may want to move away from trapeze however sadly (not sure it's still maintained?). If so, we may want to consider moving these features into NS cli directly or via dev-xcode.

@farfromrefug
Copy link
Copy Markdown
Author

I'm not sure why this change is required, this will result in duplicate entries if executed multiple times, ie. rebuilding without clearing/re-creating the xcode project.

you need one entry per target. It has to be duplicated

@farfromrefug
Copy link
Copy Markdown
Author

@rigor789 could we try to finish this one ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants