Skip to content

외부에서 브릿지 정보에 접근할 수 있도록 접근자 수정 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavinAhn merged 1 commit into from
Dec 23, 2022
Merged

외부에서 브릿지 정보에 접근할 수 있도록 접근자 수정 #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions Sources/WKJavaScriptController/WKJavaScriptController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,16 +103,16 @@ open class WKJavaScriptController: NSObject {

fileprivate weak var webView: WKWebView?

fileprivate var bridges = [MethodBridge]()
open var bridges = [MethodBridge]()

fileprivate var isInjectRequired = true

fileprivate class MethodBridge {
var nativeSelector: Selector
var isExtendJsSelector: Bool // If true, use ObjC style naming.
var isReturnRequired: Bool
open class MethodBridge {
open private(set) var nativeSelector: Selector
open fileprivate(set) var isExtendJsSelector: Bool // If true, use ObjC style naming.
open fileprivate(set) var isReturnRequired: Bool
Comment on lines +111 to +113
Copy link
Copy Markdown

@jiggag jiggag Dec 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 3가지 프로퍼티는 내부 private이라면 open이 꼭 있어야하나요???

Copy link
Copy Markdown
Collaborator Author

@DavinAhn DavinAhn Dec 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open은 getter에 대한 접근자인데 jsSelector 말고도 다른 프로퍼티를 외부에서 활용할 수 있도록 고려했어요.

Copy link
Copy Markdown

@jiggag jiggag Dec 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아! set만 private인거군요 🙀


var jsSelector: String {
open var jsSelector: String {
let selector = NSStringFromSelector(nativeSelector)
let components = selector.components(separatedBy: ":")
if components.isEmpty {
Expand All @@ -136,7 +136,7 @@ open class WKJavaScriptController: NSObject {
}
}

var argumentCount: Int {
open var argumentCount: Int {
max(NSStringFromSelector(nativeSelector).components(separatedBy: ":").count - 1, 0)
}

Expand Down