Bug in the conditional request plugin#85
Merged
Conversation
mcavage
added a commit
that referenced
this pull request
Feb 27, 2012
Bug in the conditional request plugin
Contributor
|
Awesome - thank you! |
Contributor
Author
|
No problem - looking forward to using restify instead of express for our REST services |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think there's a simple bug in the Conditional Request Plugin that actually ignores ETags. As there were no tests for this plugin I've added some (maybe not in the most DRY way though ;-) ) and fixed the bug.