Get rid of @string/@int for polyvars#770
Conversation
MoOx
left a comment
There was a problem hiding this comment.
Awesome work !
Do you think we could do something in PlatformColor for Android ? (I can handle it, I just want your opinion on this inglorious code xD
|
I have never used the Compare to TypeScript which just has this: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/16db88356a79c458dbe5d88d9706aadec1d20db5/types/react-native/index.d.ts#L6041 I don't quite understand why one can pass an array of color names, what is that used for? |
|
Yeah that's clearly some copy paste here... And why an array ? Because if you pass more than one string value to the PlatformColor function, it will treat the first value as the default and the rest as fallback depending on their availability (make more sense for "user" values, with system fallbacks). I will update PlatformColor later then. |
|
@MoOx Ah, but if you can define a type now with |
|
Exactly. |
Resurrected #767.
Merge for ReScript 10 release.