Skip to content

Documentation: Added Simple JSON Example with oAuth - #2613

Open
sgelbart wants to merge 2 commits into
request:masterfrom
sgelbart:patch-1
Open

sgelbart wants to merge 2 commits into
request:masterfrom
sgelbart:patch-1

Conversation

@sgelbart

@sgelbart sgelbart commented Mar 27, 2017 •

Copy link
Copy Markdown

I think this is a common enough scenario to warrant it own example. This assumes you are doing oAuth with your known token/keys (connecting to your own app). Not sure the best way to word the difference between that and your other example...

PR Checklist:

  • I have run npm test locally and all tests are passing.
  • I have added/updated tests for any new behavior.
  • If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]

PR Description

I think this is a common enough example to warrant it own example. This assumes you are doing oAuth with your known token/keys (connecting to your own app). Not sure the best way to word the difference between that and your other example...
Comment thread README.md Outdated

## Table of contents

- [Simple JSON with oAuth](#simple-json-with-oauth)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think OAuth is more general than oAuth

Comment thread README.md Outdated
}
},
function (error, response, body) {
if (!error && response.statusCode == 200) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

===

Comment thread README.md Outdated
console.log(body); //handle success
}
else {
console.log("Error "+response.statusCode); //handle error

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add space before and after '+'

@stale

stale Bot commented Nov 23, 2018

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Nov 23, 2018
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Co-authored-by: Francis Gulotta <wizard@roborooter.com>
@sgelbart

Copy link
Copy Markdown
Author

Don't know if this is still relevant/accurate but just noticed the comments so updated in case it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants