Repository navigation
Migrating to safe-buffer for improved security. - #2574
Merged
Merged
Conversation
This was referenced Mar 19, 2018
sabaoongfx
pushed a commit
to sabaoongfx/request-modern
that referenced
this pull request
Mar 10, 2026
Migrating to safe-buffer for improved security.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests have run and passed locally but I'm curious to see what CI says because I haven't tested against older versions of Node.js yet.
I ended up having to push a quick release of
tunnel-agentto cover this potential vulnerability fully. There are no tests fortunnel-agentso that only way to get any coverage was to push a release and then pull that new release into this PR.