Use own "isStream" helper#2427
Closed
zertosh wants to merge 1 commit intorequest:masterfrom
zertosh:remove-isstream
Closed
Use own "isStream" helper#2427zertosh wants to merge 1 commit intorequest:masterfrom zertosh:remove-isstream
zertosh wants to merge 1 commit intorequest:masterfrom
zertosh:remove-isstream
Conversation
Member
|
Is that helper in the stream module pre-v6? v4 tests are failing. |
Contributor
Author
|
Fixed, but the 6.8.1 failure seems fishy given nodejs/node#9088. In any case, that failure would be present regardless of this change since the |
Contributor
|
This PR has been closed as "abandoned" as a part of an automated cleanup. If this is a mistake and you are still interested in merging this PR, please do the following:
Thank you for your understanding. If you have any questions, please check out #2556 and feel free to comment / ask anything there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Equivalent check as
isstream, but this way related functionality is kept together for clarity (next to the preexistingisReadStream) - and you simplify the dependency graph a bit.