Skip to content
This repository was archived by the owner on Sep 27, 2023. It is now read-only.

Fixing TypeScript 4.5 type generation#519

Merged
saihaj merged 3 commits intorelay-tools:masterfrom
fxOne:513
Nov 23, 2021
Merged

Fixing TypeScript 4.5 type generation#519
saihaj merged 3 commits intorelay-tools:masterfrom
fxOne:513

Conversation

@fxOne
Copy link
Copy Markdown
Contributor

@fxOne fxOne commented Nov 23, 2021

This is a breaking change as it wont work with older TypeScript versions!

closes #513

@fxOne fxOne added the Version: Major Increment the major version when merged label Nov 23, 2021
@fxOne fxOne requested review from saihaj and sibelius November 23, 2021 20:13
@wongmjane
Copy link
Copy Markdown

wongmjane commented Nov 23, 2021

Thanks a lot!

Specifically, the breaking change is microsoft/TypeScript#45998 (allowing type-only import specifiers) which changed createImportSpecifier’s call signature,

from:

createImportSpecifier(
  propertyName: Identifier | undefined,
  name: Identifier
): ImportSpecifier;

to:

createImportSpecifier(
  isTypeOnly: boolean,
  propertyName: Identifier | undefined,
  name: Identifier
): ImportSpecifier;

@saihaj saihaj merged commit bbf8e73 into relay-tools:master Nov 23, 2021
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 23, 2021

🚀 PR was released in v15.0.0 🚀

@szakhlypa szakhlypa mentioned this pull request Feb 28, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@sibelius sibelius sibelius approved these changes

@saihaj saihaj saihaj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released Version: Major Increment the major version when merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Typescript 4.5 type generation is broken

4 participants

@fxOne @wongmjane @sibelius @saihaj