Tiny fix for misnamed macro, add a compile-test for it#1
Merged
reiver-dev merged 1 commit intoreiver-dev:masterfrom Apr 27, 2016
Merged
Tiny fix for misnamed macro, add a compile-test for it#1reiver-dev merged 1 commit intoreiver-dev:masterfrom
reiver-dev merged 1 commit intoreiver-dev:masterfrom
Conversation
Owner
|
Thank you, and sorry for not noticing it earlier. Looked into your version: nice variadic macro and overall very good repository structure. But did not quite get why do you need unused bool argument in macro and in delegate factory. |
Contributor
Author
|
The bool argument helped to collapse the macro code for MSVC, i could not figure out a shorter way to do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small macro name mismatch for static and free functions.
By the way, this code is conceptually similar to marcmo/delegates#1, also zero dependencies, zero exceptions, c++11 with variadic templates, similarly concise.