fix(clean-conversation-headers): wait for both branch tags - #9957
Open
Sebastien-Ahkrin wants to merge 2 commits into
Open
fix(clean-conversation-headers): wait for both branch tags#9957Sebastien-Ahkrin wants to merge 2 commits into
clean-conversation-headers): wait for both branch tags#9957Sebastien-Ahkrin wants to merge 2 commits into
Conversation
clean-conversation-headers): wait for both branch tags
Sebastien-Ahkrin
marked this pull request as ready for review
August 8, 2026 20:55
Member
|
Thank you! The selector should eventually just select the head branch, not use :has() due to performance concerns. Inside cleanPrHeader you can then use |
Sebastien-Ahkrin
force-pushed
the
fix/clean-conversation-header
branch
from
August 9, 2026 10:12
19cf792 to
6a088b0
Compare
|
Please avoid force-pushing to this PR. It makes it harder for reviewers to track what changed since the last review. Just push new commits on top of the branch instead — PRs are squashed on merge, so the commit history doesn't need to be clean. |
Author
|
Sorry for the force-push, wanted to reword a commit for typo. Result ended up to be the same as previous CF the gif. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #9952
This PR is here to solve the issues, that sometime the wrong ref is highlighted (posted by @fregante)
This bug happened when
Edit titlewas clicked before RGH has finished loading.I tested it on Chromium, Firefox and Safari.
What I did
We were picking the first element matching
[class^="PullRequestBranchName"]as the base branch, without checking if the head was also in the DOM. Now, we check in theobserveif both branches are in the DOM.Test URLs
Open PR (default branch): Open PR sandbox#4
Open PR (non-default branch): Fix typo Kenshin/simpread#698
Merged PR (same author): Fix bad linebreaks in
default-branch-buttonandlatest-tag-button#3402Merged PR (different author): fix for bundle-loader when using ESM parcel-bundler/parcel#78
Merged PR (different author + first published tag): Use
@primer/octicons-reacticons #3227Closed PR: Add
confirm-short-commentsfeature #4141Screenshot / GIF
GIF from my Chromium
Tell me if this looks correct for you.