fix(html-preview-link): fix button border radius in button group - #9956
Open
Sebastien-Ahkrin wants to merge 1 commit into
Open
fix(html-preview-link): fix button border radius in button group#9956Sebastien-Ahkrin wants to merge 1 commit into
html-preview-link): fix button border radius in button group#9956Sebastien-Ahkrin wants to merge 1 commit into
Conversation
html-preview-link): fix button border radius in button group
Sebastien-Ahkrin
marked this pull request as ready for review
August 8, 2026 18:45
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #9953
@fregante created an issue because the
Previewbutton was not visually grouped withRawbutton.This bug was on Safari, Chrome and Firefox (Tested and fixed on all three)
What I did
The wrapper
<div>around thePreviewlink was missing theButtonGroupitem class that GitHub uses to merge adjacent buttons' border radius.The fix copies the
classNamefrom the existingRawbutton's wrapperdivonto the newPreviewwrapper, so it picks up the same style and merges visually with the button group.Test URLs
Screenshot
Old version :
Now :
