Center the unread-anywhere icon#9874
Closed
liby wants to merge 1 commit into
Closed
Conversation
The block layout and manual offsets place the arrow above the button's vertical center. Use flex alignment so the icon follows the button geometry without hard-coded margins.
Member
|
Thank you for the PR but the position is intentional, it's meant to look like a sup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9503 and #9508.
The button uses block layout and manual icon offsets. GitHub's current button styles place the arrow above the vertical center.
This PR changes only
unread-anywhere. It uses flexbox to center the arrow. It removes the manual offsets. It keeps the button width, border, tooltip, and shortcut unchanged.Test URLs
Screenshot