quick-review - Improve reliability#9846
Merged
Merged
Conversation
quick-review - Svelte componentquick-review - Improve reliability
fregante
commented
Jul 17, 2026
Comment on lines
+91
to
+92
| // "h3" required to exclude "x more reviewers without write access" | ||
| observe('[aria-label="Select reviewers"] h3.discussion-sidebar-heading', addSidebarReviewButtons, {signal}); |
Member
Author
There was a problem hiding this comment.
Bugfix. The feature was missing there
fregante
marked this pull request as ready for review
July 17, 2026 12:38
fregante
enabled auto-merge (squash)
July 17, 2026 16:41
fregante
disabled auto-merge
July 17, 2026 16:41
fregante
enabled auto-merge (squash)
July 17, 2026 16:47
fregante
disabled auto-merge
July 17, 2026 16:48
fregante
commented
Jul 17, 2026
fregante
left a comment
Member
Author
There was a problem hiding this comment.
Made a bunch of improvements to simplify names and usage. I'm so close to just deleting the code for the old version.
| } | ||
|
|
||
| function initReviewRequestedButton(signal: AbortSignal): void { | ||
| delegate('section[aria-label="Review Request Banner"] a[type="button"]', 'click', onReviewRequestedButtonClick, { |
Member
Author
There was a problem hiding this comment.
I dropped this.
Our "Review now" button is specifically an action to quickly approve/reject a PR.
This banner is a formal invite to actually review the PR, we should not change the intent.
| const prFilesChangedTabSelector = 'a#prs-files-anchor-tab'; | ||
|
|
||
| const isNewFilesChangedExperienceEnabled = (): boolean => $(prFilesChangedTabSelector).href.endsWith('changes'); | ||
| const isOldPrFiles = (): boolean => $(prFilesChangedTabSelector).href.endsWith('files'); |
Comment on lines
-62
to
-65
| function handleReviewClick(event: DelegateEvent<MouseEvent>): void { | ||
| if (isAlteredClick(event) || !isNewFilesChangedExperienceEnabled()) { | ||
| return; | ||
| } |
Member
Author
There was a problem hiding this comment.
Conditions inlined.
Merged handleReviewClick into openReviewDialogWhenAvailable
| // Trigger data preloading | ||
| // TODO [2027-01-01]: Change `$optional` to `$()` once legacy PR files view is removed | ||
| $optional(prFilesChangedTabSelector)?.dispatchEvent(new MouseEvent('mouseover', {bubbles: true})); | ||
| $(prFilesChangedTabSelector).dispatchEvent(new MouseEvent('mouseover', {bubbles: true})); |
Member
Author
There was a problem hiding this comment.
preloadPrFilesTab is no longer called when not necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think this fixes this issue, but potentially we'll be able to just call "remount" and svelte will not trigger the internal logic code:
quick-reviewoccasionally removed and not restored #9327Test URLs
Screenshot