quick-comment-edit - Fix misplacement in PRs #9773
Open
NvanWeeghel wants to merge 1 commit into
Open
Conversation
| observe( | ||
| (isUserModerator ? '' : 'div[class*="viewerDidAuthor"] ') | ||
| reactCommentSelector + ' ' | ||
| + (isUserModerator ? '' : 'div[class*="viewerDidAuthor"] ') |
Contributor
There was a problem hiding this comment.
.react-issue-comment div[class*="viewerDidAuthor"] isn't a correct selector. This breaks editing your own comments on issues on repos you don't moderate
Contributor
There was a problem hiding this comment.
Here is my suggestion:
observe(
'div:is([class^="IssueBodyHeader"], [data-testid="comment-header"])'
+ (isUserModerator ? '' : '[class*="viewerDidAuthor" i]')
+ ' '
+ 'button[data-component="IconButton"]:has(> .octicon-kebab-horizontal)',
addQuickEditButton,
{signal},
);
Author
There was a problem hiding this comment.
Ah i didnt see that, let me check if this works.
quick-comment-edit feature to not apply to PR checksquick-comment-edit - Fix misplacement in PR checks
Author
|
test comment |
f3b5e71 to
c8cfbbd
Compare
|
Please avoid force-pushing to this PR. It makes it harder for reviewers to track what changed since the last review. Just push new commits on top of the branch instead — PRs are squashed on merge, so the commit history doesn't need to be clean. |
Author
|
Ah sorry for the force push, just a habit that i also do on other branches 😅 |
quick-comment-edit - Fix misplacement in PR checks quick-comment-edit - Fix misplacement in PRs
Member
|
On 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope the
quick-comment-editfeature to only comments and descriptionCloses #9771
Test URLs
For moderators of this repo would the page you're currently on work just fine
Screenshot
Removes the edit icon from the PR checks
While still maintaining the quick edit on description and comments
(removed the user from the screenshot for privacy reasons)
And issues also still keep working
P.S. This feature has only been gone less than a day, and i already miss it. Thanks for all the work you guys are doing to make our lives easier on GitHub :)