Skip to content

Fix closing remarks lookup for short merge SHAs#9474

Open
AjTheSpidey wants to merge 1 commit into
refined-github:mainfrom
AjTheSpidey:codex/closing-remarks-full-sha
Open

Fix closing remarks lookup for short merge SHAs#9474
AjTheSpidey wants to merge 1 commit into
refined-github:mainfrom
AjTheSpidey:codex/closing-remarks-full-sha

Conversation

@AjTheSpidey
Copy link
Copy Markdown

Summary

  • read the merge commit hash from the commit link URL instead of the visible short SHA
  • keep the existing branch_commits lookup and tag filtering behavior unchanged

Fixes #9464

Validation

  • npx eslint source/features/closing-remarks.tsx
  • npm run build:typescript
  • npm run format:check
  • npm run build:bundle
  • Verified https://github.com/npm/cli/branch_commits/a96d8f6 returns 404 while the full SHA endpoint includes branches-tag-list and v11.14.1

@github-actions github-actions Bot added the bug label May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

closing-remarks can't find tags even if "v11.0.0" exists

1 participant