Skip to content

pr-notification-link - Restore feature #9467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SunsetTechuila wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −7
Open

pr-notification-link - Restore feature #9467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions source/features/pr-notification-link.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
import * as pageDetect from 'github-url-detection';

import {getCleanPathname} from '../github-helpers/index.js';
import {commentBoxHashPr} from '../github-helpers/selectors.js';
import features from '../feature-manager.js';
import observe from '../helpers/selector-observer.js';

const regex = /\/files\/[\da-f]{40}..[\da-f]{40}$/;
Copy link
Copy Markdown
Member

@fregante fregante May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth looking for "files" everywhere across the repo to check what else needs to be updated. Including test URLs

Copy link
Copy Markdown
Member Author

@SunsetTechuila SunsetTechuila May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including test URLs

Only they can be updated, as far as I can tell after briefly checking


export function removeLinkToPrFilesTab(link: HTMLAnchorElement): void {
if (regex.test(link.pathname)) {
link.pathname = link.pathname.replace(regex, '');
link.hash = '#issue-comment-box';
if (pageDetect.isPRFiles(link)) {
// Owner + name + pull + number
link.pathname = getCleanPathname(link).split('/').slice(0, 4).join('/');
link.hash = commentBoxHashPr;
}
}

function init(signal: AbortSignal): void {
// It's ok if it's not 100% safe because trimLink's regex is super specific
observe('[href*="/pull/"][href*="/files/"][href*=".."]', removeLinkToPrFilesTab, {signal});
observe('[href*="/pull/"][href*=".."]', removeLinkToPrFilesTab, {signal});
}

void features.add(import.meta.url, {
Expand Down
Loading