Skip to content

table-input collapsible-content-button - Fix overflow#9420

Merged
fregante merged 7 commits into
mainfrom
buttons-order
May 10, 2026
Merged

table-input collapsible-content-button - Fix overflow#9420
fregante merged 7 commits into
mainfrom
buttons-order

Conversation

@fregante
Copy link
Copy Markdown
Member

@fregante fregante commented May 10, 2026

@github-actions github-actions Bot added the bug label May 10, 2026
container.classList.add('d-flex');

container.append(
container.parentElement!.append(
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I had suggested in the issue, the fix was to add the buttons outside the overflow-able element. Unfortunately we can only add them on the right due to flex + the overflow mechanism.

];

export const actionBarSelectors = [
'[data-target="action-bar.itemContainer"]', // TODO: remove after March 2025
Copy link
Copy Markdown
Member

@SunsetTechuila SunsetTechuila May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's too early to remove this selector. Gists, PRs and discussions still use non-React comment box

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, all good now

fixed

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overflow behavior also verified:

Screenshot 17

@fregante
Copy link
Copy Markdown
Member Author

#9425 (comment)

@fregante fregante merged commit 373188d into main May 10, 2026
13 checks passed
@fregante fregante deleted the buttons-order branch May 10, 2026 13:02
@fregante
Copy link
Copy Markdown
Member Author

We forgot to undo #9379 😭

@fregante fregante changed the title table-input collapsible-content-button fix overflow table-input collapsible-content-button - Fix overflow May 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

collapsible-content-button: broken table-input collapsible-content-button cause toolbar overflow

2 participants