Improve compatibility with Firefox#9171
Merged
SunsetTechuila merged 5 commits intomainfrom Apr 7, 2026
Merged
Conversation
fregante
approved these changes
Apr 7, 2026
| // Always Firefox… https://developer.mozilla.org/docs/Mozilla/Add-ons/WebExtensions/API/storage/StorageArea/setAccessLevel | ||
| const area = isFirefox() ? 'local' : 'session'; | ||
| // Don't use `isFirefox` - #9065 | ||
| const area = chrome.storage.session?.setAccessLevel === undefined ? 'local' : 'session'; |
Member
There was a problem hiding this comment.
You can drop the ===undefined and flip the condition
Member
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
Yes but the lint rule is wrong (rather the types are wrong). We can leave it as is for but eventually they'll detect === undefined just as well
Member
|
Gotta love bots 😃 |
Member
Author
This reverts commit 7b8ebda.
Member
|
Ship |
Member
Author
|
🫡 |
Member
|
|
jman-schief
reviewed
Apr 8, 2026
| "webext-alert": "^1.1.0", | ||
| "webext-base-css": "^2.1.0", | ||
| "webext-bugs": "^1.1.1", | ||
| "webext-bugs": "^2.0.1", |
There was a problem hiding this comment.
@SunsetTechuila Why was this dependency upgraded in this PR? Was it required for something specific? (I didn't see a clear motivation in the PR description).
thanks
Member
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9065
Closes #8994
Test URLs
Screenshot