Fix parsing of head branch of deleted repos - #8958
Closed
SunsetTechuila wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
@fregante this one needs your attention |
Member
|
Not sure what you're asking. If it fixes something, merge it. If an alternative fix is needed, find it 😅 or leave the issue open.
therefore an alternative should be found, just like for every other piece of code that no longer works. |
Contributor
Author
I'm asking if you have any suggestions |
Member
|
Not at this moment 😇 |
Contributor
Author
|
Then I'll create an issue instead |
SunsetTechuila
commented
Apr 16, 2026
| const {title, textContent, nextElementSibling} = referenceElement; | ||
|
|
||
| // In the old React version, we have a `title` attribute but it's used to mark deleted repos instead | ||
| // In the React version, we have a `title` attribute but it's used to mark deleted repos instead |
Contributor
Author
There was a problem hiding this comment.
test comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not actually enough to fix the issue. The value of
nextElementSibling!.textContentis"", since it's a copy button, not a tooltip - try executinggetBranches().headin the DevTools console. This applies to both old and new headers. What should we do?Test URLs
https://github.com/refined-github/refined-github/pull/3227/checks (Old header)Updated#3227
Screenshot