Conversation
|
Ready for testing now. 👍 |
|
Very cool and seems to work great. |
|
Quite an obscure bug, but when I created a new PR and it redirected to the created PR, I got this:
|
|
Somehow it probably got to make two fetches before one was complete since there’s already a |
|
I couldn't reproduce it when I did another PR, so probably some kind of obscure race condition indeed. |
+ Prevent quick repeated executions from piling up
|
That should do it. I just cache the entire |
|
Can you add it to the readme? |
|
@bfred-it I guess its not intended to work on private repo's right? |
|
You're 20 minutes too late! I think I was just missing |
|
@bfred-it I don't normally test the pr's unless I reported the issue |
|
Done in 04d32b7
|
|
|
||
| async function fetchStatus() { | ||
| const url = `${location.origin}/${getRepoURL()}/commits/`; | ||
| const dom = await fetch(url).then(r => r.text()).then(domify); |
There was a problem hiding this comment.
@bfred-it This could be:
const response = await fetch(url);
const dom = domify(await response.text());And here too:
src/content.js
88: domLoaded.then(onDomReady);
src/libs/synchronous-storage.js
30: return get().then(value => {
src/libs/utils.js
36: domLoaded.then(() => requestAnimationFrame(() => waiting.cancel()));
src/libs/api.js
3: return fetch(api + endpoint).then(res => res.json());
src/features/linkify-branch-refs.js
33: safeElementReady('.branch-name').then(el => {
src/features/show-names.js
16: .then(res => res.text());
src/features/show-recently-pushed-branches.js
18: }).then(res => res.text());
src/features/mark-unread.js
335: }).then(storage => storage.unreadNotifications);
src/features/move-account-switcher-to-sidebar.js
5: safeElementReady('.dashboard-sidebar').then(sidebar => {
Notes:
Testable pages:
Fixes #726