Meta: Use dynamic file list in Xcode by fregante · Pull Request #6612 · refined-github/refined-github

fregante · 2023-05-04T10:07:46Z

Xcode has static project file lists so if our files are dynamically created one needs to open Xcode and update the project.

This seems to add a link to the parent distribution folder so that only one item needs to be static.

Inspired by:

Use Parcel instead of Webpack #6597

sindresorhus · 2023-05-04T13:37:53Z

I think we already tried symlink before. The problem is that it copies the whole distribution folder into Resources instead of the contents of the folder. So you end up with:

Refined GitHub Extension.appex/Contents/Resources/distribution/manifest.json

I think manifest.json has to be directly inside Resources.

fregante · 2023-05-04T14:10:37Z

Can you try building and running it in Safari macOS? It seems to work correctly in the iOS Simulator (I only manage to run the dev version on macOS if I uninstall RGH completely)

fregante · 2023-05-06T16:45:44Z

Well, this works on iOS somehow but it crashes Safari macOS.

I'll move the assets to Resources/assets instead so that just asset can be a link. However I'd still ask you to try to make Resources a symlink to distribution instead

sindresorhus · 2023-05-06T20:08:43Z

I don't think Resources can be a symlink. Then we would have done that last time. I think the only other option is to go back to the script again (which has downsides I forgot): 9036cce#diff-f6596608b09878fdc971f0f15ca2f2b4fc694cf71f1908ddc5564994f9528706R242

fregante · 2023-05-07T00:15:39Z

The downsides of the scripts are that it doesn’t watch the FS so developing the extension in Safari means having to build it manually every time. Extension testing seems already broken compared to the default setup since Safari can’t see the extension until I uninstall the App Store version, usually the dev version automatically replaces it immediately.

This reverts commit 30d17c2.

fregante

Tested on macOS Safari:

content script
options page
background page (via open-all-notifications)
resolve-conflicts on https://github.com/refined-github/sandbox/pull/14/conflicts

However today iOS decided to fail building here and on main 🤷‍♂️

fregante · 2023-05-07T13:24:24Z


 /* Begin PBXBuildFile section */
+		1F9945322A07DB5E005BC236 /* resources in Resources */ = {isa = PBXBuildFile; fileRef = 1F9945312A07DB5E005BC236 /* resources */; };
+		1F9945332A07DB5E005BC236 /* resources in Resources */ = {isa = PBXBuildFile; fileRef = 1F9945312A07DB5E005BC236 /* resources */; };


Since distribution can't be changed, I added distribution/resources as a symlink:

sindresorhus · 2023-05-14T08:51:00Z

However today iOS decided to fail building here and on main 🤷‍♂️

I'm getting this too. If you look at the full log, this is the problem:

/Users/sindresorhus/Library/Developer/Xcode/DerivedData/Refined_GitHub-dshkgxrkdsfhtxedicouzyfghibo/Build/Products/Debug-iphonesimulator/Refined GitHub Extension.appex: code object is not signed at all
In subcomponent: /Users/sindresorhus/Library/Developer/Xcode/DerivedData/Refined_GitHub-dshkgxrkdsfhtxedicouzyfghibo/Build/Products/Debug-iphonesimulator/Refined GitHub Extension.appex/icon.png

sindresorhus · 2023-05-14T08:58:03Z

Fixed in main.

fregante · 2023-05-14T08:59:26Z

codesign worked for me eventually, I had to reset my keys in the keychain etc etc, hundreds of people complaining about that issue for years on Stackoverflow.

One also mentioned the possible incompatibility with folders called resources, I wonder if this PR triggered that.

sindresorhus · 2023-05-14T09:03:44Z

Hmm, actually no. Now it complains about the manifest file (main builds fine though):

/Users/sindresorhus/Library/Developer/Xcode/DerivedData/Refined_GitHub-dshkgxrkdsfhtxedicouzyfghibo/Build/Products/Debug-iphonesimulator/Refined GitHub Extension.appex: code object is not signed at all
In subcomponent: /Users/sindresorhus/Library/Developer/Xcode/DerivedData/Refined_GitHub-dshkgxrkdsfhtxedicouzyfghibo/Build/Products/Debug-iphonesimulator/Refined GitHub Extension.appex/manifest.json
Command CodeSign failed with a nonzero exit code

sindresorhus · 2023-05-14T09:06:18Z

The extension contains:

resources
Info.plist
manifest.json
Refined GitHub Extension

However, a proper extension has all the resources in a Resources directory. manifest.json cannot be at the top-level. It should also be Resources, not resources (unclear if that matters though).

fregante · 2023-05-14T09:21:28Z

-		E3919AF727E61192009C4956 /* refined-github.js.LICENSE.txt in Resources */ = {isa = PBXBuildFile; fileRef = E3919AE627E61192009C4956 /* refined-github.js.LICENSE.txt */; };
-		E3919AF827E61192009C4956 /* refined-github.js.LICENSE.txt in Resources */ = {isa = PBXBuildFile; fileRef = E3919AE627E61192009C4956 /* refined-github.js.LICENSE.txt */; };
 		E3919AF927E61192009C4956 /* manifest.json in Resources */ = {isa = PBXBuildFile; fileRef = E3919AE727E61192009C4956 /* manifest.json */; };
 		E3919AFA27E61192009C4956 /* manifest.json in Resources */ = {isa = PBXBuildFile; fileRef = E3919AE727E61192009C4956 /* manifest.json */; };


Double-check, this PR only moves the assets one level deep. Manifest.json is unchanged in Resources/manifest.json

I stupidly named this subfolder resources (for extra confusion 😅) though so you should be seeing Resources/resources/background.js

fregante · 2023-05-14T09:22:04Z

 		E3919AC127E6107E009C4956 /* Resources */ = {
 			isa = PBXGroup;
 			children = (
-				E3919AEA27E61192009C4956 /* background.js */,
-				E3919AED27E61192009C4956 /* icon.png */,
+				1F9945312A07DB5E005BC236 /* resources */,
 				E3919AE727E61192009C4956 /* manifest.json */,


Resources/resources/*

Resources/manifest.json

fregante · 2023-05-14T09:29:08Z

 			children = (
-				E3919AEA27E61192009C4956 /* background.js */,
-				E3919AED27E61192009C4956 /* icon.png */,
+				1F9945312A07DB5E005BC236 /* assets */,


I checked out this PR

Got codesign error again

Renamed this subfolder to assets

It builds now, both iOS and macOS

sindresorhus · 2023-05-14T09:40:55Z

It builds now and the extension seems to work, but the options page is blank (tested on device and simulator):

fregante · 2023-05-14T09:45:05Z

Thanks for checking! Fixed.

I'll make the options open in a new tab in a future release instead of a popup and also get the value from the manifest dynamically:

const optionsPage = browser.runtime.getManifest().options_ui?.page;

Use completely-dynamic file list in Safari

30d17c2

fregante added meta Related to Refined GitHub itself safari Related to Safari only labels May 4, 2023

fregante requested a review from sindresorhus May 4, 2023 10:07

Merge remote-tracking branch 'origin/main' into dynamic-safari

bec4c03

fregante marked this pull request as draft May 6, 2023 16:45

fregante added 2 commits May 7, 2023 21:08

Revert "Use completely-dynamic file list in Safari"

3edfd4a

This reverts commit 30d17c2.

Built into sub-folder instead

2f21d19

fregante changed the title ~~Meta: Use completely-dynamic file list in Safari~~ Meta: Use dynamic file list in Xcode May 7, 2023

Merge branch 'main' into dynamic-safari

8c11f9e

fregante marked this pull request as ready for review May 7, 2023 13:21

fregante commented May 7, 2023

View reviewed changes

Merge branch 'main' into dynamic-safari

7a3373d

fregante commented May 14, 2023

View reviewed changes

Don't call them resources

e9bb13b

fregante commented May 14, 2023

View reviewed changes

Fix popup

265242e

sindresorhus merged commit 2f8e86a into main May 14, 2023

sindresorhus deleted the dynamic-safari branch May 14, 2023 09:49

sindresorhus mentioned this pull request Sep 3, 2023

Target macOS 13, iOS 16, Safari 16.4 #6874

Merged

Uh oh!

Uh oh!

Conversation

fregante commented May 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sindresorhus commented May 4, 2023

Uh oh!

fregante commented May 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fregante commented May 6, 2023

Uh oh!

sindresorhus commented May 6, 2023

Uh oh!

fregante commented May 7, 2023

Uh oh!

fregante left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fregante May 7, 2023

Choose a reason for hiding this comment

Uh oh!

sindresorhus commented May 14, 2023

Uh oh!

sindresorhus commented May 14, 2023

Uh oh!

fregante commented May 14, 2023

Uh oh!

sindresorhus commented May 14, 2023

Uh oh!

sindresorhus commented May 14, 2023

Uh oh!

fregante May 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fregante May 14, 2023

Choose a reason for hiding this comment

Uh oh!

fregante May 14, 2023

Choose a reason for hiding this comment

Uh oh!

sindresorhus commented May 14, 2023

Uh oh!

fregante commented May 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

fregante commented May 4, 2023 •

edited

Loading

fregante commented May 4, 2023 •

edited

Loading

fregante left a comment •

edited

Loading

fregante May 14, 2023 •

edited

Loading

fregante commented May 14, 2023 •

edited

Loading