Meta: Improve release workflow#6145
Conversation
fregante
left a comment
There was a problem hiding this comment.
See the last run for details: https://github.com/refined-github/refined-github/actions/runs/3403316739/jobs/5659762409
I had to stop it once it got to the submit job.
I think the main issue is my misunderstanding of how core.exportVariable works in https://github.com/fregante/daily-version-action. Somehow the exported ENV isn't actually available outside the action
| with: | ||
| name: built | ||
| path: ${{ env.DIRECTORY }} | ||
| - if: env.DAILY_VERSION_CREATED |
There was a problem hiding this comment.
This doesn't exist so the tag is created by fregante/daily-version-action but the release isn't
See:
| - uses: actions/download-artifact@v3 | ||
| - name: Submit to Mozilla | ||
| if: matrix.command == 'firefox' | ||
| run: cd artifacts/built && npx web-ext-submit@7 |
There was a problem hiding this comment.
The built artifact is created correctly in the previous job, but artifacts/built doesn't exist. I assume that's how a parameter-less actions/download-artifact would work.
| gh release create "$DAILY_VERSION" --generate-notes refined-github-local-install.zip | ||
|
|
||
| Submit: | ||
| needs: Version |
There was a problem hiding this comment.
The condition below is fired even if needs.Version.outputs.created isn't set. The intention was to always attempt to submit to the stores even on re-runs, but I don’t think this ever worked correctly and should be dropped for now.
There was a problem hiding this comment.
This should now be ready for merge. I'll keep it here until the next release.
After that, the next step would be fregante/browser-extension-template#49 (comment)
| steps: | ||
| - uses: actions/checkout@v3 | ||
| with: | ||
| fetch-depth: 20 |
There was a problem hiding this comment.
Only needed by the previous releaser https://github.com/fregante/release-with-changelog
| run: npm test | ||
| - name: Create tag if necessary | ||
| uses: fregante/daily-version-action@v2 | ||
| - name: Update manifest.json with version ${{ env.DAILY_VERSION}} |
There was a problem hiding this comment.
Nitpic:
| - name: Update manifest.json with version ${{ env.DAILY_VERSION}} | |
| - name: Update manifest.json with version ${{ env.DAILY_VERSION }} |
Reopening of #6114
This workflow doesn't work and needs fixing.