Skip to content

Always show first-published-tag-for-merged-pr#5899

Merged
fregante merged 2 commits into
mainfrom
first-tag-after-pr
Aug 7, 2022
Merged

Always show first-published-tag-for-merged-pr#5899
fregante merged 2 commits into
mainfrom
first-tag-after-pr

Conversation

@fregante
Copy link
Copy Markdown
Member

@fregante fregante commented Aug 6, 2022

Before it was shown:

  • on released PRs
  • right after merging a PR

Now it's shown:

  • when a PR is closed
    • released? show link
    • else can release? show link
    • else show without link

Screenshot

Closed PR, can release

Screen Shot

Closed PR, cannot release

Screen Shot 8

Merging PR

text

Related


async function addLinkToCreateRelease(text = 'Now you can release this change'): Promise<void> {
if (await getReleaseCount() > 0) {
if (await getReleaseCount() === 0) {
Copy link
Copy Markdown
Member Author

@fregante fregante Aug 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

bug fixed 👆

@fregante fregante changed the title Always suggest creating a new release on closed PRs Always show first-published-tag-for-merged-pr Aug 6, 2022
@fregante fregante merged commit 409d93c into main Aug 7, 2022
@fregante fregante deleted the first-tag-after-pr branch August 7, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant