Skip some features on private user profiles#5814
Merged
Merged
Conversation
fregante
reviewed
Jul 11, 2022
Member
fregante
left a comment
There was a problem hiding this comment.
Looks good, but as I had suggested in #5222, I wonder if we should have a global “ignore errors on empty pages” instead of having manually exclude each feature.
In the runner, we’d have:
try {
init()
log()
} catch {
if is empty page or private user {
log(“feature disabled”) // only if feature logging is active
} else {
error()
}
}
Member
|
This specifically: #5222 (comment) |
fregante
approved these changes
Jul 11, 2022
Member
Author
That would better be a catch-all solution, instead of replacing explicit excludes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5356 (do I even remember that)
First thing to know: query strings (e.g.
sort=stargazers) have no effect on private profiles.rgh-sponsor-button: I'm not sure if users in the program can make their profile private, but there probably won't be a sponsor button thereset-default-repositories-type-to-sources: relies on query strings, so it doesn't work for the repositories tab. There's no organization listed either.show-user-top-repositories: relies on query strings; "popular repositories" element doesn't exist.user-local-time: can't get their events/commitsuser-profile-follower-badge: can't get their followersTest URLs
https://github.com/Centril
Screenshot
N/A