Add jump-to-conversation-close-event feature#5794
Conversation
|
Missing |
| constructor: HTMLSpanElement, | ||
| add(messageContainer) { | ||
| messageContainer.classList.add('rgh-jump-to-conversation-close-event'); | ||
| // Hide the native title |
There was a problem hiding this comment.
@fregante is this a good idea? We cannot modify the title since that is our detection, but I don't want the title "Status: Closed" tooltip to show.
There was a problem hiding this comment.
I agree that it's not particularly useful, but let's not mess with it
There was a problem hiding this comment.
It gets in the way of the other tooltip
There was a problem hiding this comment.
Can you extend the comment explaining why we need to leave the title attribute, why we can’t modify it, and why it needs to be hidden at all?
The current comment only explain what it’s doing but not why
Welcome back! |
Thanks! I moved, my computer broke and things just did not settle down until now. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Flo Edelmann <florian-edelmann@online.de>
|
Note this will fail on big PR such as #1986 But see #3813 (comment) so I don't see an issue |
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Federico Brigante <me@fregante.com>
Co-authored-by: Federico Brigante <me@fregante.com>
Co-authored-by: Federico Brigante <me@fregante.com>
My first add feature PR in a year! Last one was #4534. 🎉
Closes #4773
Test URLs
Closed Issue: refined-github/sandbox#24
Closed Issue (Not Planned): refined-github/sandbox#2
Merged PR: refined-github/sandbox#23
Closed PR: refined-github/sandbox#22
Screenshot