Restyle two tag-related features - #5416

I'd rather have a background under the tag name, it's usually short so it doesn't naturally stand out otherwise. I'm okay with either blue or gray.

I'd rather have a background under the tag name, it's usually short so it doesn't naturally stand out otherwise.

That's also one of the reason I had in the first attempt. However I think first-published-tag-for-merged-pr doesn't benefit that much from the background:

• (As said above,) it makes branch names next to it less distinctive
• With clean-conversation-headers there's really not much stuff there, so it can be easily spotted anyway

It kinda makes sense but really I think this piece of information is important enough to deserve visibility. For example in PRs it lets me know whether a PR has been released and in the commit list it acts as an instant "release notes" between versions.

Making it less visible I think lessens the impact of this feature, so its 👎 for me

Making it less visible I think lessens the impact of this feature, so its 👎 for me

Alternative design then 😅

I think the same applies, prominence is part of the feature IMHO, gray doesn't cut it.

the style is referenced from branch names, but tags are not actually branch names. This makes the blue background of branch names (in contrast to the usual gray of <code> blocks) less distinctive.

In short: the blue background is misleading. GitHub only uses that for branches, so should we.

The icon and the background already suggests some significance. Try out this PR and see if it really makes tags less to spot.

In short: the blue background is misleading. GitHub only uses that for branches, so should we.

I don’t think the color itself has any meaning for the user since this style only seems to appear in PRs headers, so claiming that it misleads the user is like saying all red cars look like Ferraris.

If you want to make a change to how first-published-tag-for-merged-pr looks I'd go in the opposite direction and make it even more noticeable somehow.

My arguments don't apply to tags-on-commits-list though so that part can be merged.

I don’t think the color itself has any meaning for the user since this style only seems to appear in PRs headers

That's not true, it is literally also in the timeline:

And where linkify-branch-references apply:

These are just a few examples, I'm pretty sure there's more.

so claiming that it misleads the user is like saying all red cars look like Ferraris.

That style is from .commit-ref and it's called "commit ref" for a reason.

I think it's fine to make small deviations from GitHub conventions when it makes sense. I agree with fregante that the highlight is part of the feature, it's small and when you're actively looking for it the color makes a difference — especially on cramped hi-def screens.

Let's try