Refactor clean-conversation-headers - #4152
Merged
yakov116 merged 21 commits intoApr 15, 2021
Merged
Conversation
kidonng
marked this pull request as draft
March 24, 2021 09:44
clean-conversation-headersfrom and into words in clean-conversation-headers
This comment has been minimized.
This comment has been minimized.
from and into words in clean-conversation-headersclean-conversation-headers
kidonng
marked this pull request as ready for review
March 24, 2021 12:46
yakov116
reviewed
Mar 24, 2021
Co-authored-by: yakov116 <16872793+yakov116@users.noreply.github.com>
fregante
reviewed
Mar 24, 2021
fregante
left a comment
Member
There was a problem hiding this comment.
Overall they look like good improvements 🙌
fregante
marked this pull request as draft
April 5, 2021 08:52
Member
|
@kidonng this really looks great! Do you have time to finish this up? |
Member
Author
|
Yeah possibly today |
Member
|
@kidonng just some feedback I used this the past day. It really looks great! |
yakov116
marked this pull request as ready for review
April 14, 2021 00:54
fregante
reviewed
Apr 14, 2021
| const author = select('.author', byline)!; | ||
| const isSameAuthor = pageDetect.isPRConversation() && author.textContent === (await elementReady('.TimelineItem .author'))!.textContent; | ||
|
|
||
| const base = select('.commit-ref', byline)!; |
Member
There was a problem hiding this comment.
Doesn't this have a .base-ref?
fregante
reviewed
Apr 15, 2021
Co-Authored-By: Fregante <opensource@bfred.it>
fregante
reviewed
Apr 15, 2021
fregante
reviewed
Apr 15, 2021
|
|
||
| // Replace the word "from" with an arrow | ||
| headBranch.previousSibling!.replaceWith(' ', <ArrowLeftIcon/>, ' '); | ||
| headBranch.previousSibling!.replaceWith(' ', <ArrowLeftIcon className="v-align-middle"/>, ' '); |
Member
There was a problem hiding this comment.
hmmm it doesn't seem to change anything here in Safari
Member
Author
|
Thanks for finishing this! I got busy in previous weeks and kinda left tracking RGH :( |
Member
|
NP I am so glad you started this I love the change! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #4145
Code readability 5x improved (possibly)
Extra test URL: parcel-bundler/parcel#78 (for #3987)
Also updated screenshot: