Help users find a feature with an interactive binary search by cheap-glitch · Pull Request #4119 · refined-github/refined-github

cheap-glitch · 2021-03-17T13:34:16Z

Screenshot

yakov116 · 2021-03-17T13:46:43Z

Your on 🔥

busches · 2021-03-17T14:48:48Z

+	// Test with all features disabled first
+	await onlyEnableFeatures(options, featuresState, []);
+	if (await confirmBug()) {
+		window.alert('It’s a native GitHub bug!');


This isn't 100% true as not all features can be disabled.

We could change the message to something like

The bug comes from a permanent CSS feature or GitHub itself.

I'd prefer not focusing on the fact that we have permanent CSS. The message could be something like

Every feature has been disabled. If you still see the bug, try disabling the whole extension.

fregante

🤩

fregante · 2021-03-17T18:31:41Z

+	// Test with all features disabled first
+	await onlyEnableFeatures(options, featuresState, []);
+	if (await confirmBug()) {
+		window.alert('It’s a native GitHub bug!');


I'd prefer not focusing on the fact that we have permanent CSS. The message could be something like

Every feature has been disabled. If you still see the bug, try disabling the whole extension.

fregante · 2021-03-17T19:25:02Z

I changed the title because while it's a meta feature, it's also user-facing and I want it to appear in the changelog

cheap-glitch · 2021-03-29T13:45:54Z

I rewrote the PR as suggested. It's still a bit rough around the edges but it works.

PS: sorry for leaving so many PRs open for so long, I had some serious hardware troubles.

Co-authored-by: Federico <me@fregante.com>

fregante · 2021-04-03T17:24:54Z

I think the conclusion is incorrect. On this page I tried identifying hide-watch-and-fork-count but it ended up telling me it was hide-useless-newsfeed-events, which is probably the other feature

sindresorhus · 2021-04-05T15:13:00Z

+			<strong>Find a feature</strong>
+		</p>
+		<p>
+			This process will help you identify what Refined GitHub feature is making changes or causing issues on GitHub.


Should we already here tell the user to first disable Refined GitHub to make sure the issue is with Refined GitHub?

I had proposed it this way at the beginning but I’m not particularly interested in that, the user can just toggle the extension if they feel this situation is likely.

If not, they can just follow the procedure as a regular bisect, and that’s just easier to reason about and code for us. The last step will be exactly this anyway: every JS feature is disabled.

But isn't it worth trying this before wasting time on the bisect?

But isn't it worth trying this before wasting time on the bisect?

Yes and no, fully disabling the extension is more effective than this anyway since we have non-disableable CSS features and code that runs outside init, e.g. #3336

I know I personally would probably disable it entirely in the first place if I'm unsure whether a bug is caused by RG, e.g. #3055 (comment)

Do you see yourself using this wizard for that step?

cheap-glitch · 2021-04-05T17:04:33Z

Tried it with native and non-native features, works great!

Small UX suggestion: how about disabling the "Yes"/"No" buttons until the page has finished loading? A few times I wrongly thought a feature didn't appear and clicked the "No" button by mistake, which means having to restart the whole process.

The only "bug" see is that it might jump from 3 steps to "last step"

If you're talking about the number of steps left displayed, yeah that might happen because it's a "worst case" prediction. We could reword the message slightly: "(at most x steps left)

Also I agree that it's better to have the "It might not be RGH" message at the end of the process, but in that case adding a little disclaimer about disabling the extension in the options page wouldn't hurt. (Even if it's already in the issue template.)

fregante · 2021-04-06T02:18:38Z

Small UX suggestion: how about disabling the "Yes"/"No" buttons until the page has finished loading? A few times I wrongly thought a feature didn't appear and clicked the "No" button by mistake, which means having to restart the whole process.

Some features load after the load event though, so it won't catch 100% of the scenarios, but it might still be an improvement.

"(at most x steps left)

heheh I think it's fine the way it is, without complicating things.

fregante · 2021-04-06T02:46:54Z

little disclaimer about disabling the extension in the options page wouldn't hurt

It's there

fregante

I haven't tested the latest revision, but after this it should be good to go

Co-authored-by: Federico <me@fregante.com>

fregante · 2021-04-08T08:35:56Z

I'll add a minimum width to avoid this on the last step:

The button moves slightly, and if you're just pressing "no" multiple times in a row without moving your mouse, suddenly the mouse will be on the "yes"

fregante · 2021-04-08T08:46:22Z

💯

cheap-glitch · 2021-04-08T08:48:40Z

Now let's see if this is actually going to be useful 😄

fregante · 2021-04-08T08:58:38Z

I needed it several times when trying to find buggy features already, so I'm confident I will again 😃

Add tool to bisect features

85f4cc1

cheap-glitch marked this pull request as draft March 17, 2021 13:34

cheap-glitch changed the title ~~Add tool to bisect features~~ Meta: Add tool to bisect features Mar 17, 2021

busches reviewed Mar 17, 2021

View reviewed changes

yakov116 added the meta Related to Refined GitHub itself label Mar 17, 2021

fregante reviewed Mar 17, 2021

View reviewed changes

fregante changed the title ~~Meta: Add tool to bisect features~~ Mechanism to find which feature is causing issues Mar 17, 2021

cheap-glitch added 2 commits March 29, 2021 11:34

Merge branch main into add-bisect

fab6c12

Rewrite bisect tool with custom UI

9dd4848

yakov116 mentioned this pull request Mar 30, 2021

Fix more-dropdown removing repo tabs container #4168

Merged

cheap-glitch commented Mar 30, 2021

View reviewed changes

Comment thread source/features/index.tsx Outdated

cheap-glitch commented Mar 30, 2021

View reviewed changes

Comment thread source/features/index.tsx Outdated

cheap-glitch commented Mar 30, 2021

View reviewed changes

Comment thread source/features/index.tsx Outdated

fregante reviewed Mar 30, 2021

View reviewed changes

Comment thread source/features/index.tsx Outdated

Comment thread source/features/index.tsx Outdated

Comment thread source/features/index.tsx Outdated

cheap-glitch added 3 commits March 31, 2021 11:10

Don't store split features array

a205908

Move bisect logic to separate function

5b850ff

Drop splitArray()

a2ceeb9

fregante reviewed Apr 3, 2021

View reviewed changes

cheap-glitch and others added 4 commits April 3, 2021 18:26

Apply suggestions from code review

9a3d56b

Co-authored-by: Federico <me@fregante.com>

Move functions to separate module

13c632c

Fix type error

88ae9a7

Restore background.ts

1aa3f91

fregante reviewed Apr 3, 2021

View reviewed changes

Comment thread distribution/options.html Outdated

Comment thread source/helpers/bisect.tsx Outdated

Comment thread source/helpers/bisect.tsx Outdated

Always show "Exit" button

348000d

Co-authored-by: Federico <me@fregante.com>

fregante reviewed Apr 3, 2021

View reviewed changes

Comment thread source/helpers/bisect.tsx Outdated

Improve UI

433f875

Co-authored-by: Federico <me@fregante.com>

fregante approved these changes Apr 5, 2021

View reviewed changes

fregante reviewed Apr 5, 2021

View reviewed changes

Comment thread source/helpers/bisect.tsx Outdated

fregante reviewed Apr 5, 2021

View reviewed changes

Comment thread source/helpers/bisect.tsx Outdated

cheap-glitch added 2 commits April 5, 2021 12:37

Move dialog styling to refined-github.css

827d87d

Disable button when reloading page

bdea928

cheap-glitch commented Apr 5, 2021

View reviewed changes

Comment thread source/refined-github.css

sindresorhus requested changes Apr 5, 2021

View reviewed changes

Disable yes/no buttons until page load

f424065

fregante approved these changes Apr 8, 2021

View reviewed changes

Comment thread distribution/options.html Outdated

Comment thread distribution/options.html

Comment thread source/helpers/bisect.tsx Outdated

Comment thread source/helpers/bisect.tsx Outdated

Comment thread source/options.tsx Outdated

cheap-glitch and others added 5 commits April 8, 2021 09:41

Fix comments wording

f581b86

Co-authored-by: Federico <me@fregante.com>

Functional programming is a lie

bdb1915

Co-authored-by: Federico <me@fregante.com>

Fix type

1ac395b

Fix options page markup

544d1cf

Lint

4ef7fb7

fregante added 4 commits April 8, 2021 15:38

Add minimum width

c02be48

Drop related label tag

8bfcd15

Drop extra log

15dbb55

Fix getMiddleStep comment

d2ce321

fregante merged commit 0ac8f8c into refined-github:main Apr 8, 2021

fregante changed the title ~~Mechanism to find features~~ Help users find a feature with an interactive binary search Apr 8, 2021

cheap-glitch deleted the add-bisect branch April 8, 2021 08:46

fregante mentioned this pull request Feb 9, 2023

Enable reaction-avatars on organization discussions #6316

Merged

fregante mentioned this pull request Nov 19, 2024

reactions-avatars - Fix feature in locked conversation #8083

Merged

Uh oh!

Conversation

cheap-glitch commented Mar 17, 2021 • edited by fregante Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshot

Uh oh!

yakov116 commented Mar 17, 2021

Uh oh!

busches Mar 17, 2021

Choose a reason for hiding this comment

Uh oh!

cheap-glitch Mar 17, 2021

Choose a reason for hiding this comment

Uh oh!

fregante Mar 17, 2021

Choose a reason for hiding this comment

Uh oh!

fregante left a comment

Choose a reason for hiding this comment

🤩

Uh oh!

fregante Mar 17, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fregante commented Mar 17, 2021

Uh oh!

cheap-glitch commented Mar 29, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fregante commented Apr 3, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sindresorhus Apr 5, 2021

Choose a reason for hiding this comment

Uh oh!

fregante Apr 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sindresorhus Apr 5, 2021

Choose a reason for hiding this comment

Uh oh!

fregante Apr 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cheap-glitch commented Apr 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fregante commented Apr 6, 2021

Uh oh!

fregante commented Apr 6, 2021

Uh oh!

fregante left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cheap-glitch commented Mar 17, 2021 •

edited by fregante

Loading

fregante Apr 5, 2021 •

edited

Loading

fregante Apr 6, 2021 •

edited

Loading

cheap-glitch commented Apr 5, 2021 •

edited

Loading