Skip to content

Restore base branch name in clean-conversation-headers - #4103

Merged
fregante merged 1 commit into
refined-github:mainfrom
cheap-glitch:restore-base-branch
Mar 19, 2021
Merged

Restore base branch name in clean-conversation-headers#4103
fregante merged 1 commit into
refined-github:mainfrom
cheap-glitch:restore-base-branch

Conversation

@cheap-glitch

@cheap-glitch cheap-glitch commented Mar 15, 2021

Copy link
Copy Markdown
Contributor

Closes #3808

Test URLs

Screenshots

Before After
Open PR (default branch)
Open PR (non-default branch)
Merged PR (same author)
Merged PR (different author)
Merged PR (different author, non-default branch)

@yakov116

Copy link
Copy Markdown
Member

We're missing one test case: a PR merged by a different author into a non-default base branch. Anyone has a link?

#3150

@fregante fregante left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still hate this, it undoes 50% of the feature

Screen Shot 7

But it works I guess

@fregante
fregante merged commit ddf0f09 into refined-github:main Mar 19, 2021
@cheap-glitch
cheap-glitch deleted the restore-base-branch branch March 19, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Base branch missing from PR view

3 participants