Skip to content

Fix console errors - #3844

Merged
yakov116 merged 6 commits into
masterfrom
console_error
Dec 29, 2020
Merged

Fix console errors#3844
yakov116 merged 6 commits into
masterfrom
console_error

Conversation

@yakov116

@yakov116 yakov116 commented Dec 25, 2020

Copy link
Copy Markdown
Member

@fregante

Copy link
Copy Markdown
Member

If it has errors on gists, it’s because it shouldn’t run on gists

@yakov116

Copy link
Copy Markdown
Member Author

Hmm I am not by a computer this second. But I think it is supposed to run. What is the comment https://github.com/sindresorhus/refined-github/issues/1305 referring to?

@fregante

Copy link
Copy Markdown
Member

It's linkify_urls_in_code, not linkifyIssues. Issue references like #123 on gists don't make sense. To be honest even references like user/repo#123 are popular enough to support gists at all for that feature.

@yakov116

Copy link
Copy Markdown
Member Author

ok will look into it

@yakov116
yakov116 merged commit 30e2a38 into master Dec 29, 2020
@yakov116
yakov116 deleted the console_error branch December 29, 2020 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

comments-time-machine-links: Cannot read property 'attributes' of null

2 participants