Markdown rich diff tooltip appears underneath diff settings bar#1308
Markdown rich diff tooltip appears underneath diff settings bar#1308ghost wants to merge 1 commit into
Conversation
|
Note that we tested this in Chrome, Firefox, Opera. Thanks. |
|
Interesting. This has the side effect of bringing the whole button above the file bar (and not just the tooltip, whose tooltip z-index is relative to the button itself so it can’t be moved on its own). Scroll 20px down in your screenshot to notice the issue. Perhaps it’s not a big deal since it happens only on hover. Then: the selector is very specific but we have the same issue on other file views, everywhere we have a file header. Can this be a bit more generic and not just for pull requests? |
|
@bfred-it Good catch. We didn’t notice that buggy behavior until after several scroll-throughs. Could we then make the tooltip appear below the buttons, or is the solution we proposed in the PR an acceptable alternative? Regarding specificity of the selector, we can only produce this behavior when there are two headers, as in the case of the PR, with the diff setting toolbar and the file header. If you happen to know of this issue in any other place, can you point us to that direction as well? Thanks. |
Ah you're correct
It is for me, but let's see what others say |
|
Closing this for now. If you want to push the alternative solution feel free to open a new PR |

Tooltips now appear above buttons on hover.
I ran
npm testand got the following output https://user-images.githubusercontent.com/19957343/39781814-7cb09b82-52cd-11e8-93c6-c4fc504443c3.pngFixes #1295