Lock review buttons after clicking#1306
Merged
Merged
Conversation
vanniktech
approved these changes
May 8, 2018
Contributor
vanniktech
left a comment
There was a problem hiding this comment.
Oh that's good. I've also recently ran into this.
sindresorhus
reviewed
May 8, 2018
|
|
||
| // To avoid double submit | ||
| const reviewButtons = document.querySelectorAll('#submit-review .form-actions button'); | ||
| reviewButtons.forEach(button => { |
fregante
approved these changes
May 9, 2018
fregante
approved these changes
May 9, 2018
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been using refined-github for some time and I'm loving it so far!
I found an issue with review buttons. Due to how it currently works, it's possible to accidentally double click a button which will lead to double submission (or however many times you manage to click it until the page reloads):
This PR adds locking to the review buttons after one of them was clicked: