One thing we should validate before going through with this is where we can find these URLs in the first place.

If there's a situation where GitHub generates encoded URLs, there's a non-zero chance that decoding it will break it.

In refined-github/refined-github#8358 I did something similar though

where we can find these URLs in the first place

?

decoding it will break it

break what exactly?

where we can find these URLs in the first place

?

github-url-detection/index.test.ts

Line 244 in 8f6bda3

expect(getRepositoryInfoAdapter('https://github.com/refined-github/sandbox/blob/bracket-in-path/foo%2F%5Bbar%5D%2Fbaz')).toMatchInlineSnapshot(`

github-url-detection/index.test.ts

Line 259 in 8f6bda3

expect(getRepositoryInfoAdapter('https://github.com/refined-github/sandbox/blob/bracket-in-path/foo%252F%5Bbar%5D%252Fbaz')).toMatchInlineSnapshot(`

github-url-detection/index.test.ts

Line 272 in 8f6bda3

expect(getRepositoryInfoAdapter('https://github.com/refined-github/sandbox/tree/%F0%9F%98%B1')).toMatchInlineSnapshot(`

Those URLs are made up. I mean where on GitHub can I find GitHub generating those URLs? We don't really have to support things that don't exist in the wild, this is what I mean. Is it only for files?

decoding it will break it

break what exactly?

What happens when you decode "folder/file-#1.md" and then re-compose the URL? Every feature that attempts to build a URL back from this will have to handle re-encoding manually.

If this helper is used locally this won't happen, but I think it's exported right?

I added some examples in the sandbox: https://github.com/refined-github/sandbox/tree/default-a/files

I think overall it makes sense, but we should check what this change means downstream, with features that are already handling decoding and others needing to properly generate URL from already-decoded parts

Those URLs are made up. I mean where on GitHub can I find GitHub generating those URLs

I don't understand. How they are "made up"? Your browser encode URLs, not GitHub. Just open those files

Is it only for files?

Files and branches

How they are "made up"?

Can I click those links? We have a sandbox specifically to create REAL URLs.

I don't understand.

You know how we ask for "test URLs" for each issue, right? We want to click those URLs and find the issue. What I asked is a repro where I can find GitHub generating those URLs. As always: REAL, existing, found in GitHub's own DOM and not typed out in the URL bar.

Of course they exist. This exists too, but it's not found in GitHub's DOM so I'm not going to write code to handle a no parameter

https://github.com///?no=luck

Can I click those links?

Yes!

GitHub's DOM

What does this have to do with the DOM? We use location in 95% of cases when we call getRepo. And location.pathname is always encoded