Rename active clients stats fields#14972
Conversation
🤖 Augment PR SummarySummary: This PR backports new client-activity and parsing statistics to improve observability. Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
6321c9c to
d174f15
Compare
…ts-stats-renamed-counters
|
@udi-speedb why rename these now? please note that in ROF it's already in use and part of grafana dashboards. renaming will cause compatibility issues between versions |
The rename was meant to better reflect what's measured — commands parsed per processInputBuffer pass, not really a "pipeline length" (a client can send N commands in one read without pipelining, and a pipelined batch can be split across reads). But you're right that breaking existing dashboards for a cosmetic win isn't worth it. I'll drop the commit and keep the original names. |
|
i can argue that it is the pipeline from redis's command processing perspective 🤷 |
This PR follows #14841
Optimize the active client statistics fields with unclear names.
Fields changes
INFO stats:avg_pipeline_length_sum->commands_per_parse_batch_sumavg_pipeline_length_cnt->commands_per_parse_batch_cntavg_pipeline_length->commands_per_parse_batch_avgCLIENT LIST/CLIENT INFO:avg-pipeline-len-sum->parse-batch-cmd-sumavg-pipeline-len-cnt->parse-batch-cntNote
Low Risk
Mostly a metric/field rename affecting observability outputs and tests; risk is limited to compatibility for users parsing the old stat names.
Overview
Renames the client/server “avg pipeline length” statistics to better reflect what’s actually being measured: commands parsed per input parsing batch.
This updates internal counters (client + global), the
INFO statsfields (including the derived average), and theCLIENT LIST/CLIENT INFOoutput keys to the newcommands_per_parse_batch*/parse-batch-*names, along with corresponding test expectations.Written by Cursor Bugbot for commit f064608. This will update automatically on new commits. Configure here.