feat: Add reading time to blog listing cards (#1766)#1824
Conversation
|
@ida-jemi is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
|
✅ Synchronized metadata from Issue #1766:
|
This comment has been minimized.
This comment has been minimized.
Adez017
left a comment
There was a problem hiding this comment.
I am not sure this much file changes required for the issue assigned on this task .
CC: @sanjay-kv @iitzIrFan
iitzIrFan
left a comment
There was a problem hiding this comment.
@ida-jemi , could you add some context on the implementation here? From a quick look, it seems the logic was initially made dynamic but later hardcoded. A short explanation of the approach and the reasoning behind it would help reviewers and maintainers understand the changes better. Thanks!
|
✅ Synchronized metadata from Issue #1766:
|
Hi @iitzIrFan! The readingTime values in index.tsx are manually calculated by reading each blog post, not arbitrary numbers. This project already stores all blog metadata statically in index.tsx (title, description, authors, tags), so adding readingTime there follows the same existing pattern. |
Hi @Adez017, I've cleaned up the PR, removed the unused plugin files and the unrelated BlogPostItem/Header change.
The reason it touches both the blog listing page and the carousel is that both are places where blog cards are displayed to users, so both need to show reading time for consistency. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Description
Fixes # 1766
Type of Change
Changes Made
Dependencies
Checklist
npm run buildand attached screenshot(s) in this PR.** npm run build crashes locally due to a GLib/Windows environment issue unrelated to these changes. Verified all changes work correctly via npm start - blog cards on /blogs page, carousel, and search all display correct read times.