Skip to content

fixed #1597 Refactor blog filtering logic for maintainability #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sanjay-kv merged 1 commit into from
May 20, 2026
Merged

fixed #1597 Refactor blog filtering logic for maintainability #1599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 11 additions & 24 deletions src/pages/blogs/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,43 +1,28 @@
import React, { type ChangeEvent } from "react";
import React from "react";
import useDocusaurusContext from "@docusaurus/useDocusaurusContext";
import Layout from "@theme/Layout";
import Link from "@docusaurus/Link";
import blogs from "../../database/blogs/index";
import Head from "@docusaurus/Head";
import { getAuthorProfiles, getAuthorTooltip } from "../../utils/authors";
import { filterBlogsBySearchTerm } from "../../utils/blogFilters";

import "./blogs-new.css";

export default function Blogs() {
const { siteConfig } = useDocusaurusContext();
const [searchInput, setSearchInput] = React.useState("");
const [searchTerm, setSearchTerm] = React.useState("");
const [filteredBlogs, setFilteredBlogs] = React.useState(blogs);

// Filter blogs after the user submits the blog search form.
React.useEffect(() => {
let filtered = blogs;

if (searchTerm.trim() !== "") {
const normalizedSearch = searchTerm.trim().toLowerCase();
filtered = filtered.filter(
(blog) =>
blog.title.toLowerCase().includes(normalizedSearch) ||
blog.description.toLowerCase().includes(normalizedSearch) ||
blog.tags?.some((tag) =>
tag.toLowerCase().includes(normalizedSearch),
),
);
}

setFilteredBlogs(filtered);
}, [searchTerm]);
const filteredBlogs = React.useMemo(
() => filterBlogsBySearchTerm(blogs, searchTerm),
[searchTerm],
);

const handleSearchChange = (e: ChangeEvent<HTMLInputElement>) => {
const handleSearchChange = (e: { target: { value: string } }) => {
setSearchInput(e.target.value);
};

const handleSearchSubmit = (e: React.FormEvent<HTMLFormElement>) => {
const handleSearchSubmit = (e: { preventDefault: () => void }) => {
e.preventDefault();
setSearchTerm(searchInput.trim());
};
Expand Down Expand Up @@ -157,7 +142,9 @@ export default function Blogs() {
<div className="articles-grid">
{filteredBlogs.length > 0 ? (
filteredBlogs.map((blog) => (
<BlogCard key={blog.id ?? blog.slug} blog={blog} />
<React.Fragment key={blog.id ?? blog.slug}>
<BlogCard blog={blog} />
</React.Fragment>
))
) : (
<div className="no-results">
Expand Down
23 changes: 23 additions & 0 deletions src/utils/blogFilters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
type BlogLike = {
title: string;
description: string;
tags?: string[];
};

export function filterBlogsBySearchTerm<T extends BlogLike>(
blogs: T[],
searchTerm: string,
): T[] {
const normalizedSearch = searchTerm.trim().toLowerCase();

if (normalizedSearch === "") {
return blogs;
}

return blogs.filter(
(blog) =>
blog.title.toLowerCase().includes(normalizedSearch) ||
blog.description.toLowerCase().includes(normalizedSearch) ||
blog.tags?.some((tag) => tag.toLowerCase().includes(normalizedSearch)),
);
}
Loading