Skip to content

refactor: extract Tooltip components to resolve ES Lint warnings #3988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theianmay merged 3 commits into from
Nov 5, 2025
+91 −53
Merged

refactor: extract Tooltip components to resolve ES Lint warnings #3988

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07616b7
refactor: extract Tooltip components to resolve ES Lint warnings
theianmay Oct 25, 2025
c572afe
Merge branch 'next' into bugfix/tooltip
theianmay Oct 26, 2025
b7f791d
Merge branch 'next' into bugfix/tooltip
theianmay Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
144 changes: 91 additions & 53 deletions packages/base/src/Tooltip/Tooltip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,83 @@ export interface TooltipProps {
animationType?: 'fade' | 'none';
}

interface PointerProps {
tooltipY: FlexStyle['top'];
dimensions: {
yOffset: number;
xOffset: number;
elementWidth: number;
elementHeight: number;
};
withPointer: boolean;
pointerColor: ColorValue;
pointerStyle?: StyleProp<ViewStyle>;
}

const Pointer: React.FC<PointerProps> = ({
tooltipY,
dimensions,
withPointer,
pointerColor,
pointerStyle,
}) => {
const { yOffset, xOffset, elementHeight, elementWidth } = dimensions;
const pastMiddleLine = yOffset > ((tooltipY as number) || 0);
if (!withPointer) {
return null;
}
return (
<View
style={{
position: 'absolute',
top: pastMiddleLine ? yOffset - 13 : yOffset + elementHeight - 2,
[I18nManager.isRTL ? 'right' : 'left']:
xOffset +
getElementVisibleWidth(elementWidth, xOffset, ScreenWidth) / 2 -
7.5,
}}
>
<Triangle
style={pointerStyle}
pointerColor={pointerColor}
isDown={pastMiddleLine}
/>
</View>
);
};

interface HighlightedButtonProps {
closeOnlyOnBackdropPress: boolean;
onPress: () => void;
style: ViewStyle;
children: React.ReactNode;
}

const HighlightedButton: React.FC<HighlightedButtonProps> = ({
closeOnlyOnBackdropPress,
onPress,
style,
children,
}) => {
if (!closeOnlyOnBackdropPress) {
return (
<Pressable
testID="tooltipTouchableHighlightedButton"
onPress={onPress}
style={style}
>
{children}
</Pressable>
);
} else {
return (
<View testID="tooltipTouchableHighlightedButton" style={style}>
{children}
</View>
);
}
};

/** Tooltips display informative text when users tap on an element.
* @usage
* ### Example
Expand Down Expand Up @@ -172,34 +249,6 @@ export const Tooltip: RneFunctionComponent<TooltipProps> = ({
isMounted.current && toggleOnPress && (visible ? onClose?.() : onOpen?.());
}, [getElementPosition, onClose, onOpen, toggleOnPress, visible]);

const Pointer: React.FC<{
tooltipY: FlexStyle['top'];
}> = ({ tooltipY }) => {
const { yOffset, xOffset, elementHeight, elementWidth } = dimensions;
const pastMiddleLine = yOffset > ((tooltipY as number) || 0);
if (!withPointer) {
return null;
}
return (
<View
style={{
position: 'absolute',
top: pastMiddleLine ? yOffset - 13 : yOffset + elementHeight - 2,
[I18nManager.isRTL ? 'right' : 'left']:
xOffset +
getElementVisibleWidth(elementWidth, xOffset, ScreenWidth) / 2 -
7.5,
}}
>
<Triangle
style={pointerStyle}
pointerColor={pointerColor}
isDown={pastMiddleLine}
/>
</View>
);
};

const TooltipHighlightedButtonStyle = React.useMemo<ViewStyle>(() => {
const { yOffset, xOffset, elementWidth, elementHeight } = dimensions;
return {
Expand All @@ -213,29 +262,6 @@ export const Tooltip: RneFunctionComponent<TooltipProps> = ({
};
}, [dimensions, highlightColor]);

const HighlightedButton: React.FC = () => {
if (!closeOnlyOnBackdropPress) {
return (
<Pressable
testID="tooltipTouchableHighlightedButton"
onPress={handleOnPress}
style={TooltipHighlightedButtonStyle}
>
{props.children}
</Pressable>
);
} else {
return (
<View
testID="tooltipTouchableHighlightedButton"
style={TooltipHighlightedButtonStyle}
>
{props.children}
</View>
);
}
};

/**
* Listen for change in layout, i.e. Portrait or Landscape
*/
Expand Down Expand Up @@ -300,8 +326,20 @@ export const Tooltip: RneFunctionComponent<TooltipProps> = ({
activeOpacity={1}
>
<View>
<HighlightedButton />
<Pointer tooltipY={tooltipStyle.top} />
<HighlightedButton
closeOnlyOnBackdropPress={closeOnlyOnBackdropPress}
onPress={handleOnPress}
style={TooltipHighlightedButtonStyle}
>
{props.children}
</HighlightedButton>
<Pointer
tooltipY={tooltipStyle.top}
dimensions={dimensions}
withPointer={withPointer}
pointerColor={pointerColor}
pointerStyle={pointerStyle}
/>
<View style={tooltipStyle} testID="tooltipPopoverContainer">
{props.popover}
</View>
Expand Down