fix(SocialIcon): handle button prop correctly#3860
Merged
arpitBhalla merged 4 commits intoreact-native-elements:nextfrom Jan 29, 2024
Merged
fix(SocialIcon): handle button prop correctly#3860arpitBhalla merged 4 commits intoreact-native-elements:nextfrom
arpitBhalla merged 4 commits intoreact-native-elements:nextfrom
Conversation
ef87ee3 to
4a7cbbf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3860 +/- ##
==========================================
+ Coverage 79.70% 79.71% +0.01%
==========================================
Files 87 87
Lines 1843 1844 +1
Branches 819 821 +2
==========================================
+ Hits 1469 1470 +1
Misses 369 369
Partials 5 5 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The SocialIcon component does not handle the button prop correctly, this PR fixes it:
Type of change
How Has This Been Tested?
exampleappChecklist
yarn docs-build-apiAdditional context