Skip to content

Fix wrong dep which breaks build, upgrade to yarn 4 and use it as task runner, rely on corepack, add script to create packages#3858

Open
darkbasic wants to merge 4 commits intoreact-native-elements:nextfrom
darkbasic:yarn4
Open

Fix wrong dep which breaks build, upgrade to yarn 4 and use it as task runner, rely on corepack, add script to create packages#3858
darkbasic wants to merge 4 commits intoreact-native-elements:nextfrom
darkbasic:yarn4

Conversation

@darkbasic
Copy link
Copy Markdown
Contributor

Motivation

  • Fixes a wrong dependency on the themed package which otherwise breaks build.
  • Upgrades to yarn 4.
  • Instead of bundling the yarn package it relies on corepack like the upstream now suggests.
  • Uses yarn 4 as task runner instead of lerna because latest lerna isn't multiplatform anymore and doesn't work on several architectures including my workstation (ppc64le).
  • Add a new package.json script to create tarball packages. Useful since react-native-elements doesn't work with yarn link.

Feel free to cherry pick the commits you want, but I suggest to merge them all.
I didn't create separate PRs because several commits depend on each other and the current HEAD is broken so it wouldn't build/pass tests otherwise.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app
  • Checked with production app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant