Skip to content

fix(Skeleton): height/width prop incorrect typing #3802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arpitBhalla merged 7 commits into from
Jun 18, 2023
Merged

fix(Skeleton): height/width prop incorrect typing #3802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7931f90
Fix issue 3799
deepakrawat08 May 31, 2023
42284b3
Merge branch 'next' into deepak/issue3799
deepak-rawat78 Jun 11, 2023
2be8217
types updated for height and width in Skeleton.tsx
deepak-rawat78 Jun 13, 2023
445f0e8
Removing styles prop from Skeleton.tsx
deepak-rawat78 Jun 13, 2023
2f9d5b3
Merge branch 'next' into deepak/issue3799
deepak-rawat78 Jun 16, 2023
8b4bc5a
Merge branch 'next' into deepak/issue3799
arpitBhalla Jun 18, 2023
8e93abf
add docs
arpitBhalla Jun 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/base/src/Skeleton/Skeleton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ export interface SkeletonProps extends ViewProps {
/**
* Width of Skeleton View
*/
width?: number;
width?: ViewStyle['width'];
/**
* Height of Skeleton View
* @default 12
*/
height?: number;
height?: ViewStyle['height'];
/**
* Type of animation
*/
Expand Down
4 changes: 2 additions & 2 deletions website/docs/components/Skeleton.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ Includes all [View](https://reactnative.dev/docs/view#props) props.
| `LinearGradientComponent` | React Component | | Custom Linear Gradient Component |
| `animation` | `none` \| `pulse` \| `wave` | `pulse` | Type of animation |
| `circle` | boolean | | show circular variant |
| `height` | number | `12` | Height of Skeleton View |
| `height` | `string` \| `number` | `12` | Height of Skeleton View |
| `skeletonStyle` | View Style | | Custom style for skeleton gradient |
| `width` | number | `100%` | Width of Skeleton View |
| `width` | `string` \| `number` | `100%` | Width of Skeleton View |

</div>